[webkit-reviews] review granted: [Bug 100393] Generate Settings from a .in file : [Attachment 173701] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 100393: Generate Settings from a .in file
https://bugs.webkit.org/show_bug.cgi?id=100393

Attachment 173701: Patch
https://bugs.webkit.org/attachment.cgi?id=173701&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173701&action=review


> Source/WebCore/page/make_settings.pl:3
> +# Copyright (C) 2011 Adam Barth <abarth at webkit.org>

I wrote this file!  I'm amazing.

> Source/WebCore/page/make_settings.pl:208
> +    substr($setterFunctionName, 3, 1) = uc(substr($setterFunctionName, 3,
1));
> +    if (substr($settingName, 0, 3) eq "css" || substr($settingName, 0, 3) eq
"xss" || substr($settingName, 0, 3) eq "ftp") {
> +	   substr($setterFunctionName, 3, 3) = uc(substr($setterFunctionName,
3, 3));
> +    }

Yeah, this is probably better than writing a general camel-case converter.