[webkit-reviews] review denied: [Bug 99310] Indexeddb doesn't work with the attached test case and "Unable to deserialize data" : [Attachment 173823] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 07:12:25 PST 2012


Yong Li <yoli at rim.com> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 99310: Indexeddb doesn't work with the attached test case and "Unable to
deserialize data"
https://bugs.webkit.org/show_bug.cgi?id=99310

Attachment 173823: Patch
https://bugs.webkit.org/attachment.cgi?id=173823&action=review

------- Additional Comments from Yong Li <yoli at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173823&action=review


> Source/WebCore/bindings/js/SerializedScriptValue.cpp:1012
> +	       writeLittleEndian<uint8_t>(const_cast<Vector<uint8_t>& >(value),
NullTag);

I don't like this const_cast, nor the unneeded null in String. Why don't we
change "length" instead?


More information about the webkit-reviews mailing list