[webkit-reviews] review denied: [Bug 101516] Handle gesture events on scrollbars. : [Attachment 172881] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied Robert Flack
<flackr at chromium.org>'s request for review:
Bug 101516: Handle gesture events on scrollbars.
https://bugs.webkit.org/show_bug.cgi?id=101516

Attachment 172881: Patch
https://bugs.webkit.org/attachment.cgi?id=172881&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172881&action=review


Looks generally good. Some requests for a final round.

> Source/WebCore/ChangeLog:10
> +	   Handle gesture events on scrollbars.
> +	   https://bugs.webkit.org/show_bug.cgi?id=101516
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Test: fast/events/touch/gesture/gesture-scrollbar.html
> +
> +	   * page/EventHandler.cpp:

Please improve your changelog with some more details about motivation,
advantages, etc of your change.

> Source/WebCore/page/EventHandler.cpp:387
> +    m_scrollGestureHandlingScrollbar = 0;

I think it would read better a m_scrollbarHandlingScrollGesture .