[webkit-reviews] review denied: [Bug 101349] GStreamer reference handling fix : [Attachment 172586] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Thiago Santos
<thiago.sousa.santos at collabora.com>'s request for review:
Bug 101349: GStreamer reference handling fix
https://bugs.webkit.org/show_bug.cgi?id=101349

Attachment 172586: Patch
https://bugs.webkit.org/attachment.cgi?id=172586&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172586&action=review


> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:220
> -    GRefPtr<GstPadTemplate> padTemplate =
adoptGRef(gst_static_pad_template_get(&srcTemplate));
> +    GRefPtr<GstPadTemplate> padTemplate =
adoptGRef(WTF::refGPtr(gst_static_pad_template_get(&srcTemplate)));

I think it would make more sense to simply avoid using adoptGRef here.