[webkit-reviews] review denied: [Bug 101348] CustomEvent: Allow taking in a serialized value during initialization. : [Attachment 172585] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 6 07:45:48 PST 2012
Adam Barth <abarth at webkit.org> has denied sadrul at chromium.org's request for
review:
Bug 101348: CustomEvent: Allow taking in a serialized value during
initialization.
https://bugs.webkit.org/show_bug.cgi?id=101348
Attachment 172585: Patch
https://bugs.webkit.org/attachment.cgi?id=172585&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172585&action=review
> Source/WebCore/ChangeLog:10
> + If a CustomEvent is initialized using a serialized value, then for
each access
> + to |detail|, the value is deserialized first. This way, each world
gets a different
> + deserialization.
In your patch, you're only calling deserialize once per CustomEvent object
though.
More information about the webkit-reviews
mailing list