[webkit-reviews] review granted: [Bug 101004] quoteCSSString() always creates a 16 bit string : [Attachment 171967] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 101004: quoteCSSString() always creates a 16 bit string
https://bugs.webkit.org/show_bug.cgi?id=101004

Attachment 171967: Patch
https://bugs.webkit.org/attachment.cgi?id=171967&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171967&action=review


> Source/WebCore/css/CSSParser.cpp:10640
> +    if (string.length() >= (std::numeric_limits<unsigned>::max() / 3) - 2)

Not new code, but seems to me there are extra parentheses here. Also seems
strange to use >= here instead of just >.

> Source/WebCore/css/CSSParser.cpp:10641
> +	   return "";

Should probably use emptyString() here since it makes more efficient code.