[webkit-reviews] review denied: [Bug 101003] RegExp.prototype.toString Should Produce an 8 bit JSString if possible. : [Attachment 171964] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 101003: RegExp.prototype.toString Should Produce an 8 bit JSString if
possible.
https://bugs.webkit.org/show_bug.cgi?id=101003

Attachment 171964: Patch
https://bugs.webkit.org/attachment.cgi?id=171964&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171964&action=review


> Source/JavaScriptCore/runtime/RegExpObject.cpp:258
> +	       else if (sizeof(CharacterType) > 1) {
> +		   if (ch == 0x2028)
> +		       result.appendLiteral("u2028");
> +		   else
> +		       result.appendLiteral("u2029");
> +	       }

I don’t think this technique is going to work portably; we’ll get warnings on
some compilers. I think we need a separate inline function for this that we
overload for the 8-bit and 16-bit character types.

Patch otherwise looks fine.