[webkit-reviews] review granted: [Bug 101029] Fix build warning [-Wswitch] : [Attachment 172012] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 2 10:45:52 PDT 2012


Alexey Proskuryakov <ap at webkit.org> has granted  review:
Bug 101029: Fix build warning [-Wswitch]
https://bugs.webkit.org/show_bug.cgi?id=101029

Attachment 172012: Patch
https://bugs.webkit.org/attachment.cgi?id=172012&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172012&action=review


> Source/WebCore/ChangeLog:6
> +	   Reviewed by NOBODY (OOPS!).

You should have marked the patch for review, not just commit queue. Commit
queue won't land a patch with this line unless it's marked r+.

I'll mark it r+, because it seems clear that this was your intention.


More information about the webkit-reviews mailing list