[webkit-reviews] review granted: [Bug 100977] [WK2][EFL] Crash when calling WebOpenPanelResultListenerProxy::cancel() after PageClient is destroyed : [Attachment 172084] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 2 10:41:57 PDT 2012


Alexey Proskuryakov <ap at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 100977: [WK2][EFL] Crash when calling
WebOpenPanelResultListenerProxy::cancel() after PageClient is destroyed
https://bugs.webkit.org/show_bug.cgi?id=100977

Attachment 172084: Patch
https://bugs.webkit.org/attachment.cgi?id=172084&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172084&action=review


So does the Mac port.

- (void)dealloc
{
    _data->_page->close();
...

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:162
> +    // Close the page in case some other objects hold
> +    // a reference to it and keep it alive.

I'm not convinced that this comment adds much value.


More information about the webkit-reviews mailing list