[webkit-reviews] review denied: [Bug 97801] Support invalidation tracking for composited layers : [Attachment 171916] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 1 13:21:48 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has denied vollick at chromium.org's
request for review:
Bug 97801: Support invalidation tracking for composited layers
https://bugs.webkit.org/show_bug.cgi?id=97801

Attachment 171916: Patch
https://bugs.webkit.org/attachment.cgi?id=171916&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171916&action=review


> Source/WebCore/page/FrameView.cpp:3650
> +static void setTracksRepaintsRecursive(Frame* frame, bool trackRepaints)
> +{
> +    if (!frame)
> +	   return;
> +
> +    if (RenderView* root = frame->contentRenderer())
> +	   root->compositor()->setTracksRepaints(trackRepaints);
> +
> +    for (unsigned i = 0; i < frame->tree()->childCount(); ++i)
> +	   setTracksRepaintsRecursive(frame->tree()->child(i), trackRepaints);
> +}

You can do this non-recursively; the FrameTree can enumerate all subframes for
you.


More information about the webkit-reviews mailing list