[webkit-reviews] review requested: [Bug 97801] Support invalidation tracking for composited layers : [Attachment 171916] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 1 13:15:29 PDT 2012


vollick at chromium.org has asked	for review:
Bug 97801: Support invalidation tracking for composited layers
https://bugs.webkit.org/show_bug.cgi?id=97801

Attachment 171916: Patch
https://bugs.webkit.org/attachment.cgi?id=171916&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #40)
> (From update of attachment 171890 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=171890&action=review
>
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:2066
> > +bool RenderLayerCompositor::isTrackingRepaints() const
> > +{
> > +	 FrameView* frameView = m_renderView ? m_renderView->frameView() : 0;
> > +	 if (!frameView)
> > +	     return false;
> > +	 FrameView* rootFrameView = frameView->frame()->tree()->top()->view();
> > +	 if (!rootFrameView)
> > +	     return false;
> > +	 return rootFrameView->isTrackingRepaints();
> > +}
>
> This code is going to run in release builds. I wonder if we should cache the
flag in RLC?

Sounds good. Done. I've put another r? on this in case I've gone about this the
wrong way.


More information about the webkit-reviews mailing list