[webkit-reviews] review granted: [Bug 87094] GeneratorGeneratedImage should cache images for no pattern draw : [Attachment 144796] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jin Yang
<jin.a.yang at intel.com>'s request for review:
Bug 87094: GeneratorGeneratedImage should cache images for no pattern draw
https://bugs.webkit.org/show_bug.cgi?id=87094

Attachment 144796: Patch
https://bugs.webkit.org/attachment.cgi?id=144796&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144796&action=review


> Source/WebCore/ChangeLog:3
> +	   GeneratorGeneratedImage should cache images for no pattern draw

"for no pattern draw" is confusing here. It should be "for the non-tiled
drawing case" or something.

> Source/WebCore/ChangeLog:9
> +	   By compared to generate image on the fill, it will loss litter pixel
precision

I'm not sure what "loss litter" means. Do you mean "lose a little"?

You should mention the performance gains.