[webkit-reviews] review granted: [Bug 87824] Factor DeferrableOneShotTimer out of GraphicsContextCG/GeneratorGeneratedImage : [Attachment 144724] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 87824: Factor DeferrableOneShotTimer out of
GraphicsContextCG/GeneratorGeneratedImage
https://bugs.webkit.org/show_bug.cgi?id=87824

Attachment 144724: patch
https://bugs.webkit.org/attachment.cgi?id=144724&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144724&action=review


Nice.

> Source/WebCore/platform/Timer.h:127
> +	   // again, which might result in rescheduling the system timer and
that

s/and that/which

> Source/WebCore/platform/Timer.h:155
> +    bool m_shouldRestartWhenTimerFires;
> +    double m_delay;

Putting the bool last might get you better packing and a smaller object.