[webkit-reviews] review denied: [Bug 87738] Make TextureMapper work with GraphicsSurface. : [Attachment 144563] patch for review.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 87738: Make TextureMapper work with GraphicsSurface.
https://bugs.webkit.org/show_bug.cgi?id=87738

Attachment 144563: patch for review.
https://bugs.webkit.org/attachment.cgi?id=144563&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144563&action=review


> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:31
> +void TextureMapperDirectBackingStore::setGraphicsSurface(uint32_t
graphicsSurfaceToken, const IntSize& surfaceSize)

This should be inside #if USE(GRAPHICS_SURFACE)

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:33
> +    if (graphicsSurfaceToken != m_graphicsSurfaceToken) {

Early return

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:36
> +			   GraphicsSurface::SupportsSoftwareRead

Wy do you need SoftwareRead?

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:57
> +   
static_cast<TextureMapperGL*>(textureMapper)->drawTextureRectangleARB(m_texture
Id, 0, m_graphicsSurfaceSize, targetRect, adjustedTransform, opacity, mask);

This is very Mac specific. Maybe it should be inside OS(DARWIN)?

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:370
> +void TextureMapperGL::drawTextureRectangleARB(uint32_t texture, Flags flags,
const IntSize& textureSize, const FloatRect& targetRect, const
TransformationMatrix& modelViewMatrix, float opacity, const BitmapTexture*
maskTexture)

Mac specific, I think.