[webkit-reviews] review denied: [Bug 86214] Fix and enable WebGL for WebKit2 on Qt : [Attachment 144752] patch for review.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 30 07:03:43 PDT 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has denied Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 86214: Fix and enable WebGL for WebKit2 on Qt
https://bugs.webkit.org/show_bug.cgi?id=86214

Attachment 144752: patch for review.
https://bugs.webkit.org/attachment.cgi?id=144752&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144752&action=review


Awesome progress, see comments.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:115
> +	   window->show();

You don't need to show the window. Just call create(). Then you don't have to
set its geometry to outside the screen.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:130
> +	       GraphicsSurface::SupportsSoftwareWrite
> +	       | GraphicsSurface::SupportsSoftwareRead

Why these two?

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:132
> +	       | GraphicsSurface::SupportsCopyFromTexture

Seems like you're not really using CopyToTexture, but rather something like
TextureTarget.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:292
> +    m_graphicsSurface = GraphicsSurface::create(contextSize,
m_surfaceFlags);

In which case would it be 0?
Shouldn't we destroy the surface if it's 0?


More information about the webkit-reviews mailing list