[webkit-reviews] review granted: [Bug 87746] [Chromium] Remove assertions on state in Prerender.cpp : [Attachment 144559] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Gavin Peters <gavinp at chromium.org>'s
request for review:
Bug 87746: [Chromium] Remove assertions on state in Prerender.cpp
https://bugs.webkit.org/show_bug.cgi?id=87746

Attachment 144559: Patch
https://bugs.webkit.org/attachment.cgi?id=144559&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I talked with Gavin directly abou this patch.  Here's what I said:

[[[
Yes, that's entirely possible.
The way this can happen is you take a reference to a DOM node in an
iframe and then either navigate to iframe to a new URL or remove the
iframe from the DOM entirely.  Now, stop() will be called on the DOM
node, but it will still be in the DOM tree.  You can then remove it
from the DOM tree using removeChild.
]]]

He's going to write a test for this in the Chromium repo where it can be an
end-to-end test.  Ideally, we'd have a LayoutTest too, but Gavin tells me that
there's not enough of the prerendering machinery in DumpRenderTree for that to
be a meaningful test.

Gavin, once you add the test to Chromium, can you include a link in this bug?