[webkit-reviews] review granted: [Bug 87315] [chromium] make WebTransformationMatrix object usable by non-webkit code : [Attachment 144576] removed virtual, added comment, added compile assert

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 87315: [chromium] make WebTransformationMatrix object usable by non-webkit
code
https://bugs.webkit.org/show_bug.cgi?id=87315

Attachment 144576: removed virtual, added comment, added compile assert
https://bugs.webkit.org/attachment.cgi?id=144576&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144576&action=review


> Source/Platform/chromium/public/WebTransformationMatrix.h:52
>      void reset();

do we still need a reset()? looks like there's no implementation or caller of
it now and we have makeIdentity() to turn an instance into a
default-constructed instance

> Source/WebCore/platform/chromium/support/WebTransformationMatrix.cpp:67
> +    bool isEqual = (m_private == t.m_private);
>      return isEqual;

I would just do:

return m_private == other.m_private