[webkit-reviews] review granted: [Bug 66574] Canvas 2D - Source rectangles that overlap the source image boundary, not supported by drawImage : [Attachment 144581] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Justin Novosad <junov at chromium.org>'s
request for review:
Bug 66574: Canvas 2D - Source rectangles that overlap the source image
boundary, not supported by drawImage
https://bugs.webkit.org/show_bug.cgi?id=66574

Attachment 144581: Patch
https://bugs.webkit.org/attachment.cgi?id=144581&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144581&action=review


> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1273
> +    if (srcRect.isEmpty()) {

Do we have test coverage for negative sizes?

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1278
> +    if (dstRect.isEmpty())

Ditto?