[webkit-reviews] review granted: [Bug 29919] HashTable.h has using directives for std::pair and std:make_pair : [Attachment 144558] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 29 13:26:54 PDT 2012
Darin Adler <darin at apple.com> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 29919: HashTable.h has using directives for std::pair and std:make_pair
https://bugs.webkit.org/show_bug.cgi?id=29919
Attachment 144558: Patch
https://bugs.webkit.org/attachment.cgi?id=144558&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
Normally it’s safer to do such patches in pairs. The first patch adds all the
"std::" prefixes. Then the second one only removes the “using”. That way, if
there is a problem and a roll-out is necessary, we only roll out a small
change.
More information about the webkit-reviews
mailing list