[webkit-reviews] review granted: [Bug 87747] [chromium] Stop dropping texture limits when the layer tree host becomes invisible, and initialize with 0 allocation. : [Attachment 144586] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted Michal Mocny
<mmocny at chromium.org>'s request for review:
Bug 87747: [chromium] Stop dropping texture limits when the layer tree host
becomes invisible, and initialize with 0 allocation.
https://bugs.webkit.org/show_bug.cgi?id=87747

Attachment 144586: Patch
https://bugs.webkit.org/attachment.cgi?id=144586&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144586&action=review


R=me.  Thanks!

>> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:-153
>> -	m_memoryAllocationBytes =
TextureManager::highLimitBytes(deviceViewportSize());
> 
> Original patch set these to (0, false), but that is the default value given
in the constructor, and it means we overwrite any potential allocations
received before initialization.
> At the moment, we won't receive any allocations before this point (except in
tests), but its unnecessary to blindly overwrite here anyways.

Ah, that makes a lot of sense.