[webkit-reviews] review granted: [Bug 87742] [perf-test] Add a benchmark for querySelector() : [Attachment 144550] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 87742: [perf-test] Add a benchmark for querySelector()
https://bugs.webkit.org/show_bug.cgi?id=87742

Attachment 144550: Patch
https://bugs.webkit.org/attachment.cgi?id=144550&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144550&action=review


We probably want one more case where the node is deep in the tree (i.e. 20-50
levels of nesting).

> PerformanceTests/Parser/query-selector-last.html:5
> +</body>

Why are you closing body here?

> PerformanceTests/Parser/query-selector-last.html:7
> +for (var i = 0; i < 1000; i++) {

Is 1000 enough to make a difference?

> PerformanceTests/Parser/query-selector-last.html:11
> +  var div = document.createElement("div");
> +  div.id = "foo";
> +  div.className = "bar";
> +  document.body.appendChild(div);

Nit: 2-space indentation.