[webkit-reviews] review granted: [Bug 87419] [BlackBerry] Implement select popup and remove old hook to air popup : [Attachment 143899] updated patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Crystal Zhang <haizhang at rim.com>'s
request for review:
Bug 87419: [BlackBerry] Implement select popup and remove old hook to air popup
https://bugs.webkit.org/show_bug.cgi?id=87419

Attachment 143899: updated patch
https://bugs.webkit.org/attachment.cgi?id=143899&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=143899&action=review


Looks good.

> Source/WebCore/Resources/blackberry/popupControlBlackBerry.css:66
> +}

I think this could have been placed in WebCore/css too, but this works as well.


> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:147
> +	   const WTF::Vector<HTMLElement*>& items = m_element->listItems();

You do not need the WTF:: prefix.