[webkit-reviews] review granted: [Bug 86719] Submit button doesn't submit the form if the form is wrapped by an anchor tag : [Attachment 143901] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 24 14:58:05 PDT 2012
Darin Adler <darin at apple.com> has granted Pablo Flouret <pablof at motorola.com>'s
request for review:
Bug 86719: Submit button doesn't submit the form if the form is wrapped by an
anchor tag
https://bugs.webkit.org/show_bug.cgi?id=86719
Attachment 143901: Patch
https://bugs.webkit.org/attachment.cgi?id=143901&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=143901&action=review
> Source/WebCore/dom/Node.cpp:2784
> + dispatchScopedEvent(event.get());
This can just be event, no need for event.get().
> Source/WebCore/dom/Node.cpp:2863
> + if (dispatchDOMActivateEvent(detail, event))
> + event->setDefaultHandled();
What about other callers of dispatchDOMActivateEvent? Is this the only call
site that needs this change?
More information about the webkit-reviews
mailing list