[webkit-reviews] review denied: [Bug 42679] WebKitTestRunner needs layoutTestController.setUserStyleSheetEnabled : [Attachment 143884] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Dinu Jacob <dinu.jacob at Nokia.com>'s
request for review:
Bug 42679: WebKitTestRunner needs layoutTestController.setUserStyleSheetEnabled
https://bugs.webkit.org/show_bug.cgi?id=42679

Attachment 143884: Patch
https://bugs.webkit.org/attachment.cgi?id=143884&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=143884&action=review


> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:404
> +    WKRetainPtr<WKStringRef> emptyUrl = WKStringCreateWithUTF8CString("");

This leaks. It needs an adoptWK.

> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:411
> +    m_userStyleSheetLocation = WKStringCreateWithJSString(location);

This leaks. It needs an adoptWK.