[webkit-reviews] review granted: [Bug 87414] Mac bots crashing under PluginInfo destructor : [Attachment 143873] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 24 14:41:57 PDT 2012


Darin Adler <darin at apple.com> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 87414: Mac bots crashing under PluginInfo destructor
https://bugs.webkit.org/show_bug.cgi?id=87414

Attachment 143873: Patch
https://bugs.webkit.org/attachment.cgi?id=143873&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=143873&action=review


> Source/WebKit2/UIProcess/WebContext.cpp:642
> +    RunLoop::main()->dispatch(bind(&WebContext::sendDidGetPlugins, this,
requestID, pluginInfos.release()));

It seems like right here might be a great place to give a comment about why we
need to do this with a pointer.


More information about the webkit-reviews mailing list