[webkit-reviews] review granted: [Bug 87340] Web Inspector: Breakpoints Pane should not show context menu with no breakpoints : [Attachment 143730] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 24 04:17:28 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has granted Vivek Galatage
<vivekgalatage at gmail.com>'s request for review:
Bug 87340: Web Inspector: Breakpoints Pane should not show context menu with no
breakpoints
https://bugs.webkit.org/show_bug.cgi?id=87340
Attachment 143730: Patch
https://bugs.webkit.org/attachment.cgi?id=143730&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143730&action=review
> Source/WebCore/inspector/front-end/BreakpointManager.js:141
> + breakpointsCount: function()
Nit: I would call it breakpointCount, but this is also ok. Also, you really
want hasBreakpoints() here!
More information about the webkit-reviews
mailing list