[webkit-reviews] review granted: [Bug 87346] Web Inspector: introduce console proxy object for HeapSnapshot worker. : [Attachment 143745] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 87346: Web Inspector: introduce console proxy object for HeapSnapshot
worker.
https://bugs.webkit.org/show_bug.cgi?id=87346

Attachment 143745: Patch
https://bugs.webkit.org/attachment.cgi?id=143745&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143745&action=review


> Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:67
> +	      
window[message.object][message.method].apply(window[message.object],
message.arguments);

You should call methods on console only, otherwise, worker can run arbitrary
code on the front-end which is effectively the reversed dependency.