[webkit-reviews] review granted: [Bug 87184] [chromium] Layers on main thread should get a RenderSurface for animating transform only if masksToBounds is true also : [Attachment 143400] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 87184: [chromium] Layers on main thread should get a RenderSurface for
animating transform only if masksToBounds is true also
https://bugs.webkit.org/show_bug.cgi?id=87184

Attachment 143400: Patch
https://bugs.webkit.org/attachment.cgi?id=143400&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143400&action=review


> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:-227
> -    // On the main thread side, animating transforms are unknown, and may
cause a RenderSurface on the impl side.
> -    // Since they are cheap, we create a rendersurface for all animating
transforms to cover these cases, and so
> -    // that we can consider descendants as not animating relative to their
target to aid culling.

I don't think we have to dump the entire comment.  Having the
transformToParentIsKnown() bit explained is useful