[webkit-reviews] review granted: [Bug 86261] Removing the last child of an anonymous table or table section leaves the anonymous wrapper : [Attachment 143426] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 20:43:13 PDT 2012


Julien Chaffraix <jchaffraix at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 86261: Removing the last child of an anonymous table or table section
leaves the anonymous wrapper
https://bugs.webkit.org/show_bug.cgi?id=86261

Attachment 143426: Patch
https://bugs.webkit.org/attachment.cgi?id=143426&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143426&action=review


The queues have been acting weird on your previous attachments. Assuming you
double-check that the failure is not a real regression, r=me.

> LayoutTests/ChangeLog:20
> +	   * platform/chromium/test_expectations.txt:
> +	   * platform/efl/test_expectations.txt:
> +	   * platform/gtk/test_expectations.txt:
> +	   *
platform/mac-snowleopard/fast/table/anonymous-table-wrapper-cleanup-expected.pn
g: Added.
> +	   *
platform/mac-snowleopard/fast/table/anonymous-table-wrapper-cleanup-expected.tx
t: Added.
> +	   * platform/mac/test_expectations.txt:
> +	   * platform/qt/test_expectations.txt:

No need for all this complicated stuff: using Ahem, font size and no
font-smoothing, your result should be cross-platform so just move the
anonymous-table-wrapper-cleanup-expected.* files next to the test and no need
to touch any test_expectation.txt (on top of that you forgot win).


More information about the webkit-reviews mailing list