[webkit-reviews] review granted: [Bug 83086] auto margins on flexbox should allocate space in the flex direction : [Attachment 142812] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 21 15:35:03 PDT 2012
Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 83086: auto margins on flexbox should allocate space in the flex direction
https://bugs.webkit.org/show_bug.cgi?id=83086
Attachment 142812: Patch
https://bugs.webkit.org/attachment.cgi?id=142812&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Code looks good. There's a comment at the end of
RenderFlexibleBox::computeMainAxisPreferredSizes that you need to update to be
a bit more accurate.
More information about the webkit-reviews
mailing list