[webkit-reviews] review denied: [Bug 67329] WebSocket should have EventTarget on the prototype chain : [Attachment 110260] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 15:28:41 PDT 2012


Adam Barth <abarth at webkit.org> has denied Dominic Cooney
<dominicc at chromium.org>'s request for review:
Bug 67329: WebSocket should have EventTarget on the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=67329

Attachment 110260: Patch
https://bugs.webkit.org/attachment.cgi?id=110260&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Without commenting one way or another as to whether this is something we'd like
to do, this patch, as written, combines too many changes.  For example,
renaming JSEventTarget.cpp to JSEventTargetCustom.cpp can be done in a separate
patch and would reduce the noise in this patch.


More information about the webkit-reviews mailing list