[webkit-reviews] review granted: [Bug 12234] Using createContextualFragment to insert a <script> does not cause the script to execute : [Attachment 142890] Fixes the bug

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 12234: Using createContextualFragment to insert a <script> does not cause
the script to execute
https://bugs.webkit.org/show_bug.cgi?id=12234

Attachment 142890: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=142890&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142890&action=review


ok

> Source/WebCore/html/parser/HTMLConstructionSite.cpp:340
> +    // For createContextualFragment, the specifications say to mark it
parser-inserted and already-started and later unmark them.
> +    // However, we short circuit that logic to avoid the subtree traversal
to find script elements since scripts can never see
> +    // those flags or effects thereof

Thanks for adding this comment.  Can we add a link to the spec?  We like to do
that in the parser because we track the spec so closely.  (nit: please add a .
at the end of the sentence.)