[webkit-reviews] review denied: [Bug 86969] Match Firefox restrictions to window.blur and window.focus : [Attachment 142917] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied jochen at chromium.org's request for
review:
Bug 86969: Match Firefox restrictions to window.blur and window.focus
https://bugs.webkit.org/show_bug.cgi?id=86969

Attachment 142917: Patch
https://bugs.webkit.org/attachment.cgi?id=142917&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142917&action=review


I wonder if all ports want this change.  Do you think we should have a
WebCore::Setting to enable this new behavior?  It might be worth asking on
webkit-dev to see if folks would like such a setting.

> Source/WebCore/ChangeLog:9
> +	   Disallow window.blur altogether, and only allow window.focus to be
> +	   invoked from the context that created this very window.

This patch doesn't seem to change blur at all...

> Source/WebCore/ChangeLog:11
> +	   No new tests yet. I guess this will break some existing tests as
well (OOPS!)

Looks like it only broke one test.

> Source/WebCore/page/Chrome.cpp:170
> +bool Chrome::canSetFocus() const
> +{
> +    return m_client->canSetFocus();
> +}

There's no need for this sort of do-nothing function.  The callers can just
talk to the client directly.

> Source/WebCore/page/ChromeClient.h:94
> +	   virtual bool canSetFocus() const { return false; }

Is the plan to override this function at some point?  I'm not sure I understand
the role it plays in this patch.