[webkit-reviews] review granted: [Bug 86935] REGRESSION(r117501): IconDatabase asserts on startup in synchronousIconForPageURL(). : [Attachment 142843] Pretentious patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 86935: REGRESSION(r117501): IconDatabase asserts on startup in
synchronousIconForPageURL().
https://bugs.webkit.org/show_bug.cgi?id=86935

Attachment 142843: Pretentious patch
https://bugs.webkit.org/attachment.cgi?id=142843&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=142843&action=review


> Source/WebCore/loader/icon/IconDatabase.cpp:1529
> +	   toRetain = m_urlsToRetain;
> +	   toRelease = m_urlsToRelease;
> +	   m_urlsToRetain.clear();
> +	   m_urlsToRelease.clear();

I think you could use swap here.