[webkit-reviews] review granted: [Bug 86385] [regression] animatedType crash when animations end : [Attachment 142604] Update per reviewer comments

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Philip Rogers
<pdr at google.com>'s request for review:
Bug 86385: [regression] animatedType crash when animations end
https://bugs.webkit.org/show_bug.cgi?id=86385

Attachment 142604: Update per reviewer comments
https://bugs.webkit.org/attachment.cgi?id=142604&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142604&action=review


Excellent work Philip! r=me. Not setting cq+, as you might want to fixup these
comments before landing:

> LayoutTests/svg/animations/svg-two-animate-elements-crash-expected.svg:1
> +<svg xmlns="http://www.w3.org/2000/svg" onload="load()">

The onload="" should be removed.

> LayoutTests/svg/animations/script-tests/multiple-animations-ending.js:337
> +	   ["an1", 0.0,   sample1],
> +	   ["an1", 0.499,   sample2],

We usually align those sample lines.