[webkit-reviews] review granted: [Bug 42689] Move setEditingBehavior() from layoutTestController to window.internals : [Attachment 142776] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Caio Marcelo de
Oliveira Filho <cmarcelo at webkit.org>'s request for review:
Bug 42689: Move setEditingBehavior() from layoutTestController to
window.internals
https://bugs.webkit.org/show_bug.cgi?id=42689

Attachment 142776: Patch
https://bugs.webkit.org/attachment.cgi?id=142776&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142776&action=review


Very nice patch!

> Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:657
> +void DumpRenderTreeSupportQt::setEditingWindowsBehavior(QWebPage* page)

setWindowsEditingBehavior ? useWindowsBehaviorAsEditingBehavior ?

I think it could be a bit more clear

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:311
> +	   // FIXME: Remove this once blackberry calls resetInternalsObject().

bug number?