[webkit-reviews] review granted: [Bug 76574] Assertion failure in BidiResolver::commitExplicitEmbedding() (!inIsolate() || m_currentExplicitEmbeddingSequence.isEmpty()) at wikipedia.org : [Attachment 142376] Now with 100% moar spellin

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 76574: Assertion failure in BidiResolver::commitExplicitEmbedding()
(!inIsolate() || m_currentExplicitEmbeddingSequence.isEmpty()) at wikipedia.org
https://bugs.webkit.org/show_bug.cgi?id=76574

Attachment 142376: Now with 100% moar spellin
https://bugs.webkit.org/attachment.cgi?id=142376&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142376&action=review


>> Source/WebCore/ChangeLog:20
>> +	    the same result as this now should more explicitly.
> 
> This is a lovely explanation, but it doesn't actually explain the solution,
which I believe from the code is to commit embedding upon entering an isolate?
Ahh, I read the description in the test case, and that seems to be the case.
Couldn't hurt to have a one-line description here to that affect.

I still want a description of what exactly the fix is here (you mention what
else could have been done, but not what *was* done :)

> LayoutTests/fast/text/bidi-isolate-embedding-crash.html:10
> +inside the isolate and is not affected by the outer embeddings. -->

How about a link to the bug?