[webkit-reviews] review granted: [Bug 86823] [GTK] Allow to attach/detach the inspector in WebKit2 : [Attachment 142667] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 86823: [GTK] Allow to attach/detach the inspector in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=86823

Attachment 142667: Patch
https://bugs.webkit.org/attachment.cgi?id=142667&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142667&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:438
> -    return FALSE;
> +    return TRUE;

These look like a somewhat unrelated fix. In the interest of better
bisectability, can you land these three in a separate commit? rs=me on doing
that

> Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp:156
> +    // This method is called to decide whether to attach the inspector or
not depending on whether
> +    // the inspector view fits into the window. Attach is implemented by the
client, so return 0
> +    // when the client doesn't implement attach, to make sure the inspector
is never attached.

I don't understand this comment, who would return 0 here?