[webkit-reviews] review denied: [Bug 86602] [Forms] Refactor HTMLFormCollection : [Attachment 142687] updated patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 86602: [Forms] Refactor HTMLFormCollection
https://bugs.webkit.org/show_bug.cgi?id=86602

Attachment 142687: updated patch
https://bugs.webkit.org/attachment.cgi?id=142687&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142687&action=review


> Source/WebCore/html/HTMLFormCollection.cpp:53
> +static const Vector<FormAssociatedElement*>&
formControlElements(HTMLElement* base)

You moved these function to HTMLFormCollection.  So we can make them member
functions of HTMLFormCollection and the 'base' argument is not needed.

> Source/WebCore/html/HTMLFormCollection.cpp:55
> +    ASSERT(base && base->hasTagName(formTag));

nit: You should separate this ASSERT into two.

  ASSERT(base);
  ASSERT(base->hasTagName(formTag));

in order to know which condition fails.

> Source/WebCore/html/HTMLFormElement.h:149
>  
> -    friend class HTMLFormCollection;
> -
>      typedef HashMap<RefPtr<AtomicStringImpl>, RefPtr<HTMLFormControlElement>
> AliasMap;

great!