[webkit-reviews] review granted: [Bug 86576] [V8][Refactoring] Support an optional 'message' argument for throwTypeError() : [Attachment 142464] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 17 07:41:51 PDT 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 86576: [V8][Refactoring] Support an optional 'message' argument for
throwTypeError()
https://bugs.webkit.org/show_bug.cgi?id=86576

Attachment 142464: Patch
https://bugs.webkit.org/attachment.cgi?id=142464&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142464&action=review


> Source/WebCore/bindings/v8/V8Proxy.cpp:614
> -    return throwError(TypeError, "Type error");
> +    return throwError(TypeError, (message ? message : "Type error"));

You don't need the outer ( ) around the ? : operator.


More information about the webkit-reviews mailing list