[webkit-reviews] review granted: [Bug 86579] [V8][Refactoring] Replace throwError("message", XXXError) with throwError(XXXError, "message") : [Attachment 142164] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 86579: [V8][Refactoring] Replace throwError("message", XXXError) with
throwError(XXXError, "message")
https://bugs.webkit.org/show_bug.cgi?id=86579

Attachment 142164: Patch
https://bugs.webkit.org/attachment.cgi?id=142164&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142164&action=review


> Source/WebCore/bindings/v8/V8NPObject.cpp:95
> -	     return throwError("NPMethod called on non-NPObject",
V8Proxy::ReferenceError);
> +	       return V8Proxy::throwError(V8Proxy::ReferenceError, "NPMethod
called on non-NPObject");

Can we move throwError and the type enumeration out of V8Proxy?