[webkit-reviews] review granted: [Bug 86573] [chromium] Get text direction at the start and end of selection. : [Attachment 142152] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 16 19:34:17 PDT 2012
Adam Barth <abarth at webkit.org> has granted Hao Zheng <zhenghao at chromium.org>'s
request for review:
Bug 86573: [chromium] Get text direction at the start and end of selection.
https://bugs.webkit.org/show_bug.cgi?id=86573
Attachment 142152: Patch
https://bugs.webkit.org/attachment.cgi?id=142152&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142152&action=review
I wonder at what point it makes sense to split off a WebSelection object that
has all these APIs.
> Source/WebKit/chromium/public/WebWidget.h:180
> +#if defined(ANDROID)
Please remove this ifdef. This API isn't Android specific.
More information about the webkit-reviews
mailing list