[webkit-reviews] review granted: [Bug 86665] Use pixelSnappedLogicalHeight for TableSection layout : [Attachment 142329] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 86665: Use pixelSnappedLogicalHeight for TableSection layout
https://bugs.webkit.org/show_bug.cgi?id=86665

Attachment 142329: Patch
https://bugs.webkit.org/attachment.cgi?id=142329&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142329&action=review


> Source/WebCore/rendering/RenderBox.h:77
> +    int pixelSnappedLogicalHeight() const { return
style()->isHorizontalWritingMode() ? pixelSnappedHeight() :
pixelSnappedWidth(); }
> +    int pixelSnappedLogicalWidth() const { return
style()->isHorizontalWritingMode() ? pixelSnappedWidth() :
pixelSnappedHeight(); }

So sad that we have all these redundant accessors.  One would think that a
logicalSize() might make more sense. :)