[webkit-reviews] review requested: [Bug 86051] [chromium] Scale all compositor output by the defaultDeviceScaleFactor : [Attachment 142387] Patch

[bugzilla-daemon at webkit.org]

Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 86051: [chromium] Scale all compositor output by the
defaultDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=86051

Attachment 142387: Patch
https://bugs.webkit.org/attachment.cgi?id=142387&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
Alright new patch!

- The deviceScaleFactor in the compositor is set during initialization through
CCSettings.
- We save this deviceScaleFactor in WebViewImpl as m_deviceScaleInCompositor.
Then we can do deviceScaleFactor()/m_deviceScaleInCompositor, and that tells us
the deviceScaleFactor component of the pageScaleFactor. Right now that's going
to be either equal to 1 (on ChromeOS) or deviceScaleFactor() (on Android).
- Also the above lets us get rid of all the if (isFixedLayoutModeEnabled())
crap.
- NCCH is to its GraphicsLayer what RLB is to other GraphicsLayers. It should
know the scale at which the contents of the GraphicsLayer will be displayed, so
I am keeping the pageScale and deviceScale factors in the NCCH, so it knows
when to tell the GraphicsLayer things changed, and so it can give the
deviceScale and pageScale (1) that it should use.