[webkit-reviews] review granted: [Bug 86650] <video> elements with no video tracks report false for webkitSupportsFullscreen. : [Attachment 142323] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 86650: <video> elements with no video tracks report false for
webkitSupportsFullscreen.
https://bugs.webkit.org/show_bug.cgi?id=86650

Attachment 142323: Patch
https://bugs.webkit.org/attachment.cgi?id=142323&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=142323&action=review


> Source/WebCore/ChangeLog:3
> +	   HLS streams in <video> elements report false for
webkitSupportsFullscreen.

This should be updated.

> Source/WebCore/ChangeLog:15
> +	   With the new Full Screen API, the restriction that only video
elements with
> +	   video tracks can enter full screen seems arbitrary.	HLS streams
will occasionally
> +	   determine they have video tracks long after loadedmetadata, which
breaks websites
> +	   who check for webkitSupportsFullscreen().  Relax the restriction on
> +	   webkitSupportsFullscreen() for ports where the Full Screen API is
enabled and
> +	   supported so as to no longer require hasVideo().

The HLS detail probably isn't worth mentioning in the change log, the same
timing detail could happen for other formats or media engines.

> LayoutTests/media/media-fullscreen-inline.html:28
> -		       },
> +		       }

Making sure this test will work in old versions of IE? ;-)