[webkit-reviews] review granted: [Bug 86664] Make window-property-shadowing-name.html fail faster : [Attachment 142325] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 86664: Make window-property-shadowing-name.html fail faster
https://bugs.webkit.org/show_bug.cgi?id=86664

Attachment 142325: Patch
https://bugs.webkit.org/attachment.cgi?id=142325&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142325&action=review


Feel free to ignore the nits.

> LayoutTests/fast/dom/Window/window-property-shadowing-name.html:16
> +var pass = finish.bind(null, "PASS");
> +var fail = finish.bind(null, "FAIL");

Nit: don't need these methods anymore, you can just call them inline below.

> LayoutTests/fast/dom/Window/window-property-shadowing-name.html:24
> +var w = window.open("javascript:void 0", "test");
> +if (w === window)

Nit: no need for the local variable.