[webkit-reviews] review granted: [Bug 82698] ShadowRoot.selection should return the selection whose range is in a shadow tree. : [Attachment 142171] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 82698: ShadowRoot.selection should return the selection whose range is in a
shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=82698

Attachment 142171: Patch
https://bugs.webkit.org/attachment.cgi?id=142171&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142171&action=review


> Source/WebCore/ChangeLog:25
> +	   (WebCore::TreeScope::getSelection):
> +	     When shadow DOM feature is not enabled, we want to use the same
instance of DOMSelection
> +	     among Document and ShadowRoot.

We normally start description immediately after: followed by a single space,
and we don't indent descriptions by two-spaces.

> Source/WebCore/ChangeLog:29
> +	     Since node could be null, I've added a node check code.

Ditto.

> Source/WebCore/ChangeLog:43
> +	     Gets the corresponding node in the m_treeScope from the Position.

Ditto.

> Source/WebCore/ChangeLog:46
> +	     Gets the corresponding node offset in the m_treeScope from the
Position.

Ditto.