[webkit-reviews] review denied: [Bug 86582] [Performance test] Add a micro benchmark for div.firstChild getter : [Attachment 142173] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 86582: [Performance test] Add a micro benchmark for div.firstChild getter
https://bugs.webkit.org/show_bug.cgi?id=86582

Attachment 142173: Patch
https://bugs.webkit.org/attachment.cgi?id=142173&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142173&action=review


> PerformanceTests/Bindings/first-child.html:15
> +    for (var i = 0; i < 10000000; i++)
> +	   div.firstChild;

You shouldn't be able to use a smaller value like 10000 since runPerSecond will
auto-adjust the number of function calls per iteration.
Also, you should create element inside a setup function (use step: function ()
{~}).