[webkit-reviews] review granted: [Bug 84312] [Chromium] Added more params to Chromium-Webkit print api to implement auto fit to page functionality. : [Attachment 141495] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 13:30:32 PDT 2012


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted kmadhusu
<kmadhusu at chromium.org>'s request for review:
Bug 84312: [Chromium] Added more params to Chromium-Webkit print api to
implement auto fit to page functionality.
https://bugs.webkit.org/show_bug.cgi?id=84312

Attachment 141495: Patch
https://bugs.webkit.org/attachment.cgi?id=141495&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141495&action=review


> Source/WebKit/chromium/public/WebPrintParams.h:60
> +	     , printScalingOption(WebPrintScalingOptionFitToPrintableArea) { }

nit: indentation

unindent the comma-prefixed rows by 2 spaces

> Source/WebKit/chromium/public/WebPrintParams.h:64
> +	     , printableArea(printableArea)

nit: indentation


More information about the webkit-reviews mailing list