[webkit-reviews] review granted: [Bug 86236] [chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on chromium linux : [Attachment 141982] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Varun Jain
<varunjain at chromium.org>'s request for review:
Bug 86236: [chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on
chromium linux
https://bugs.webkit.org/show_bug.cgi?id=86236

Attachment 141982: Patch
https://bugs.webkit.org/attachment.cgi?id=141982&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141982&action=review


> Source/WebCore/platform/DragData.cpp:28
> +#if !PLATFORM(CHROMIUM) || (!OS(CHROMEOS) && !OS(LINUX))

I would remove this #if.  It's harmless to include these files on Chromium.

> Source/WebCore/platform/DragData.cpp:58
> +#if !PLATFORM(CHROMIUM) || (!OS(CHROMEOS) && !OS(LINUX))

I would make this just !PLATFORM(CHROMIUM).  We can use the m_modifierKeyState
on all version of Chromium, right?